test: allow underscores in hash for server routes preload links#33106
Merged
alan-agius4 merged 1 commit intoangular:mainfrom Apr 30, 2026
Merged
test: allow underscores in hash for server routes preload links#33106alan-agius4 merged 1 commit intoangular:mainfrom
alan-agius4 merged 1 commit intoangular:mainfrom
Conversation
Updates the regular expressions in server-routes-preload-links.ts to allow underscores in the generated file hashes (changing [a-zA-Z0-9]{8} to [a-zA-Z0-9_]{8}).
This ensures that the test correctly identifies modulepreload links when the hash contains an underscore, preventing failures due to overly strict matching.
alan-agius4
added
action: review
crisbeto
approved these changes
Apr 30, 2026
alan-agius4
added
action: merge
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the regular expressions in the server-rendering E2E tests to include underscores in the expected file hash patterns. The feedback suggests using the more concise \w shorthand in place of [a-zA-Z0-9_] and recommends refactoring the repeated regex patterns into constants or helper functions to improve maintainability.
Collaborator
Author
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the regular expressions in server-routes-preload-links.ts to allow underscores in the generated file hashes (changing [a-zA-Z0-9]{8} to [a-zA-Z0-9_]{8}).
This ensures that the test correctly identifies modulepreload links when the hash contains an underscore, preventing failures due to overly strict matching.